Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H4HIP: Move pkgs to be internal #384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gjenkins8
Copy link
Member

No description provided.

@gjenkins8 gjenkins8 changed the title H4HIP: Move implementation packages to be internal/private H4HIP: Move pkgs to be internal Feb 2, 2025
Copy link
Contributor

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action packages provide the business logic the Helm CLI uses in a reusable manner. But, other pieces of software aren't required to use them and often don't. The other packages are regularly used by software using the SDK.

For example...

  • The Flux helm-controller directly uses many different packages on the proposed list to move.
  • The helm-mapkubeapis plugin, maintained by the Helm project, uses packages outside of action. It needs to get at the releases and make changes to them which requires using the building block packages.

I'm aware of numerous other applications that use a wide variety of Helm packages.

We can't anticipate all their needs to create higher level abstractions (e.g., in the action package) and it would be too much work to act on all their requests. This is why providing access to the building blocks is useful. I don't think we should make them internal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants